Skip to content

DESENG-811: Implement Helm chart for MET Web #2621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NatSquared merged 15 commits into from
May 12, 2025
Merged

DESENG-811: Implement Helm chart for MET Web #2621

NatSquared merged 15 commits into from
May 12, 2025

Conversation

@NatSquared
Copy link
Collaborator

@NatSquared NatSquared commented May 8, 2025

Also add OIDC configuration endpoint and environment variable handling

Issue #: 🎟️ DESENG-811

  • Feature Add Helm chart and templates for MET Web
    • Created a helm chart for the MET Web deployment.
    • Migrated existing resources to Helm templates.
    • Removed several unused ConfigMap values
    • Removed JWT/OIDC related values in favor of requesting the data from the MET API (single source of truth).
      • Created an endpoint at /api/oidc_config to return the OIDC configuration for the MET API.
    • Modified the Docker entrypoint to generate a config script from REACTAPP environment variables at startup.
      • The config script is then served alongside the app at runtime.
  • Bugfix Updated existing templates to set minReplicas and maxReplicas for the HPA (matching met-web) rather than trying to configure it on the Deployment, which has no effect.

User Guide update ticket (if applicable): N/A

NatSquared added 12 commits May 7, 2025 14:39
@NatSquared
DESENG-811: Implement Helm chart for MET Web
1d34aa6 
Also add OIDC configuration endpoint and environment variable handling
@NatSquared
Fix quotes in JavaScript variable generation for consistency
c8ef808
@NatSquared
DESENG-811: Recategorize changes to existing templates as bugfix in c…
5723771 
…hangelog
@NatSquared
DESENG-811: Add ENV variable to template
bd67585
@NatSquared
DESENG-811: Fix export syntax for REACT_APP_VARS_JS in docker-entrypo…
ee5f2b9 
…int.sh
@NatSquared
Improvements to substitution handling in config.js, docker, and nginx
20b66d4
@NatSquared
DESENG-811: Fix typo in key in OIDC endpoint
9ef65a3
@NatSquared
DESENG-811: Remove trailing slashes from API URLs in configmap.yaml
38f73bd
@NatSquared
DESENG-811: Increase ActiveDeadlineSeconds to exceed timeoutSeconds
c19a540
@NatSquared
DESENG-811: Update REACT_APP_API_URL to use site URL
9a8ed7a
@NatSquared
DESENG-811: Don't uppercase environment name
dfb36a9
@NatSquared
DESENG-811: Update changelog
51e7f09
@NatSquared NatSquared changed the title Deseng 811/met web helm chart DESENG-811: Implement Helm chart for MET Web May 8, 2025
@NatSquared NatSquared marked this pull request as ready for review May 8, 2025 22:28
@NatSquared NatSquared requested review from Baelx and jareth-whitney May 8, 2025 22:28
@NatSquared NatSquared force-pushed the DESENG-811/met-web-helm-chart branch from 3f973d9 to 16b33f2 Compare May 8, 2025 22:53
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Baelx
Baelx approved these changes May 12, 2025
View reviewed changes
Copy link
Contributor

@Baelx Baelx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many great, helpful comments in this! Thanks for adding those endpoints to get around React's env var quirks.

@NatSquared NatSquared merged commit 0474bd3 into DESENG-811-use-helm-charts May 12, 2025
2 checks passed
@NatSquared NatSquared deleted the DESENG-811/met-web-helm-chart branch May 12, 2025 18:32
@NatSquared NatSquared mentioned this pull request May 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jareth-whitney jareth-whitney Awaiting requested review from jareth-whitney

1 more reviewer

@Baelx Baelx Baelx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NatSquared @Baelx